Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
receipt+ optionalruntime_metadata) by updatingREADME.md,QUICKSTART.md,EXAMPLES.md,DEVELOPER_EXPERIENCE.md, andDEPLOYMENT_GUIDE.md.typescript-sdk/package.jsonto1.1.0, lowered engine tonode >=20, addedCommandResponseenvelope andnormalizeCommandResponse()to normalize legacy blended responses, madeverifyReceipt()accept eitherreceiptor full envelope and always verify the canonicalreceipt, and surfaced protocol constants (commonsVersion,packageVersion). Updated CLI (src/cli.ts) to print the envelope and added averifycommand. Updated tests and smoke scripts.python-sdk/pyproject.tomland package__version__to1.1.0, introducedCanonicalReceipt/CommandResponse/RuntimeMetadatatypes, addednormalize_command_response()in the client, ensuredCommandLayerClientreturns the{ "receipt", "runtime_metadata" }envelope, and updatedverify_receipt()to accept envelope or receipt while always verifying the canonicalreceipt. Updated Python docs and tests accordingly.test_vectors/*to v1.1.0 canonical receipts and updated cross-SDK runtime tests inruntime/tests/and SDK unit tests to validate the new envelope and verification semantics.npm pack --dry-run, and to run Python lint/typecheck/tests + packagebuild/twinechecks.Testing
cd typescript-sdk && npm ci && npm run typecheck && npm testwhich built artifacts and executed unit + template + CLI smoke tests; all tests passed (38 passed, 0 failedin JS unit template runs) andnpm pack --dry-runproduced a clean package tarball.cd python-sdk && python -m pip install --no-build-isolation -e .thenpython -m ruff check . && python -m mypy commandlayer && python -m pytest tests/ -v; lint, mypy, and all tests passed (18 passed, 0 failed).node --test runtime/tests/*.mjs) using the built TypeScript package; tests passed.python -m buildcould not be run in this environment initially because thebuildmodule was not installed here; CI workflow was updated to performpython -m build+twine checkso packaging checks run in CI (local editable install + test suite succeeded).Files changed (high level): root docs (
README.md,QUICKSTART.md,EXAMPLES.md,DEVELOPER_EXPERIENCE.md,DEPLOYMENT_GUIDE.md), TypeScript SDK (package.json,src/index.ts,src/cli.ts, tests, scripts), Python SDK (pyproject.toml,commandlayer/*, tests, docs), workflows (.github/workflows/*), andtest_vectors/*(regenerated v1.1.0 fixtures).Codex Task