Conversation
Why: CI failures were opaque when the test server failed to initialize with signing env inputs. Contract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
server.mjsvia an absolute path from the test file so startup does not depend on ambiguous cwd behavior.RECEIPT_SIGNING_PRIVATE_KEY_PEM_B64,RECEIPT_SIGNING_PUBLIC_KEY_B64, andRECEIPT_SIGNER_ID.stdout/stderrand include those logs in thrown boot errors to surface real startup failures instead of a generic timeout.kidvalue from the generated key material.Testing
npm run checkand the server file syntax check completed successfully.npm run test:unitand all unit tests passed.npm test(unit tests plustests/smoke.mjs) and the full test suite, including smoke, passed.Codex Task