Skip to content

[runtime] Harden dual-version route test boot diagnostics#53

Merged
GsCommand merged 1 commit intomainfrom
codex/fix-ci-failure-for-dual-version-routes-pr
Apr 27, 2026
Merged

[runtime] Harden dual-version route test boot diagnostics#53
GsCommand merged 1 commit intomainfrom
codex/fix-ci-failure-for-dual-version-routes-pr

Conversation

@GsCommand
Copy link
Copy Markdown
Contributor

Motivation

  • Make the versioned-routes test deterministic and diagnosable when the test-spawned server fails to start under CI.

Description

  • Resolve and spawn server.mjs via an absolute path from the test file so startup does not depend on ambiguous cwd behavior.
  • Align the test's signer environment with the runtime's production env contract by using only RECEIPT_SIGNING_PRIVATE_KEY_PEM_B64, RECEIPT_SIGNING_PUBLIC_KEY_B64, and RECEIPT_SIGNER_ID.
  • Capture child stdout/stderr and include those logs in thrown boot errors to surface real startup failures instead of a generic timeout.
  • Remove an unused test-only derived kid value from the generated key material.

Testing

  • Ran npm run check and the server file syntax check completed successfully.
  • Ran npm run test:unit and all unit tests passed.
  • Ran npm test (unit tests plus tests/smoke.mjs) and the full test suite, including smoke, passed.

Codex Task

Why: CI failures were opaque when the test server failed to initialize with signing env inputs.
Contract impact: none
@GsCommand GsCommand merged commit 319d792 into main Apr 27, 2026
1 check failed
@GsCommand GsCommand deleted the codex/fix-ci-failure-for-dual-version-routes-pr branch April 28, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant