Skip to content

[runtime] Short-circuit cached-only /verify schema checks early #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GsCommand wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[runtime] Short-circuit cached-only /verify schema checks early #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 23 additions & 24 deletions server.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1731,8 +1731,31 @@ app.post("/verify", async (req, res) => {

const proof = receipt?.metadata?.proof;
const proofCanonical = String(proof?.canonical_id || proof?.canonical || "");
const verb = String(receipt?.x402?.verb || "").trim();
const runtimeCoreReceipt = normalizeReceiptForRuntimeCoreVerify(receipt);

if (wantSchema && VERIFY_SCHEMA_CACHED_ONLY && !hasValidatorCached(verb)) {
warmQueue.add(verb);
startWarmWorker();

return res.status(202).json({
ok: false,
checks: {
schema_valid: false,
hash_matches: null,
signature_valid: null,
ens_match: wantEns ? null : null,
},
errors: {
schema_errors: [{ message: "validator_not_warmed_yet" }],
signature_error: null,
},
reason: "validator_not_warmed_yet",
retry_after_ms: 1000,
...instancePayload(),
});
}

const verifyLogic = async () => {
if (!proof?.signature_b64 || !proof?.hash_sha256) {
return res.status(400).json({
Expand Down Expand Up @@ -1862,33 +1885,9 @@ app.post("/verify", async (req, res) => {

if (wantSchema) {
schemaOk = false;
const verb = String(receipt?.x402?.verb || "").trim();

if (!verb) {
schemaErrors = [{ message: "missing receipt.x402.verb" }];
} else if (VERIFY_SCHEMA_CACHED_ONLY && !hasValidatorCached(verb)) {
warmQueue.add(verb);
startWarmWorker();

return res.status(202).json({
ok: false,
checks: {
schema_valid: false,
hash_matches: hashMatches,
signature_valid: signatureValid,
ens_match: wantEns ? true : null,
},
values: {
verb: receipt?.x402?.verb ?? null,
signer_id: proof?.signer_id ?? null,
pubkey_source: pubSrc,
claimed_hash: proof?.hash_sha256 ?? null,
ens: ensExpect,
},
errors: { schema_errors: [{ message: "validator_not_warmed_yet" }], signature_error: sigErr },
retry_after_ms: 1000,
...instancePayload(),
});
} else {
try {
const validate = VERIFY_SCHEMA_CACHED_ONLY ? validatorCache.get(verb)?.validate : await getValidatorForVerb(verb);
Expand Down
Loading