Conversation
Why: verify timeouts must surface as retryable service outages so callers do not mislabel valid receipts as invalid. Contract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/verifyrequests that time out were being reported as generic application failures that looked like cryptographic proof failures, causing callers to treat valid receipts as invalid./verifysurface (no browser frontend), so the minimal change is to the API response and logging so clients can distinguish transient failures.Description
/verifytimeout handling inserver.mjsso whenverifytimes out (errorverify_timeout) the server returns HTTP502withfailure_type: "availability",retryable: true,reason: "verify_service_unavailable", and a user-facingmessageexplaining the retry recommendation, and sets proofchecksfields tonull.want_ens,want_schema,refresh,strict_kid,verb,signer_id) to help operators diagnose ENS/schema/ proxy or process stalls.runtime/tests/runtime-signing.test.mjsthat simulates a stalled ENS/RPC path and asserts the502availability response and new fields.README.mdanddocs/OPERATIONS.mdso clients/operators treat502as transient availability (not proof invalidation) and know likely runtime causes to inspect.Testing
npm testand it completed successfully (all tests passed, including smoke checks).node --test runtime/tests/runtime-signing.test.mjsand the new availability test passed.ens=1&refresh=1plus a shortVERIFY_MAX_MSresults in a502response,ok: false,failure_type: "availability",retryable: true, and nullified proofchecks.Codex Task