Conversation
Why: remove a misleading placeholder test and make the runtime's legacy verification surface and health alias behavior explicit without changing production behavior. Contract impact: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
runtime/src/receipt-verification.jsis compatibility-only and not the production verification path./healthzalias while preserving identical behavior to/health.Description
sdk/python-sdk/tests/test_verification.pyto avoid giving a false impression of Python-side CI coverage.runtime/src/receipt-verification.jswith a clear legacy/compatibility comment and markedverifyReceiptas deprecated for production flows to point engineers to@commandlayer/runtime-core.Legacy verification helperorLegacy receipt verification compatibilityto reduce confusion about what is production.server.mjsto addbuildHealthPayload()andsendHealth()and wired both/healthand/healthztosendHealth()so/healthzno longer usesapp._routerinternals.README.mdanddocs/OPERATIONS.mdlanguage to reflect the legacy status of the verifier and absence of a repo-local Python verification test in the Node CI workflow.Testing
npm run checkfor syntax verification and it completed successfully.npm run test:unit(Node unit tests) and all unit tests passed.npm test(unit tests + smoke) and the full test suite including the smoke script completed successfully.Codex Task