[runtime] serve commons verbs on v1.1.0 routes#19
Merged
Conversation
Why: the live runtime must expose enabled Commons verbs on the real v1.1.0 route surface and advertise that version consistently in runtime metadata.\n\nContract impact: updates route and service metadata defaults from v1.0.0 to v1.1.0 without changing /health, /verify, signer identity, or ENS behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
v1.1.0release so enabled verbs are served on realv1.1.0routes./health,/verify, signer identity, and ENS verification while changing only the route/version defaults and minimal test/script fixtures.Description
server.mjsby settingAPI_VERSIONandSERVICE_VERSIONto"1.1.0"so the mounted verb routes resolve toPOST /<verb>/v1.1.0instead ofv1.0.0.x402version/entry strings and thedescriberesponseversionproperty to use theAPI_VERSIONconstant so generated receipts and entries reflectv1.1.0.app.post(/${verb}/v${API_VERSION})) so the endpoint style is preserved, and explicitly avoid touching/verify,/health, signer logic, ENS resolution, or schema validation behaviors.tests/smoke.mjs,runtime/tests/runtime-signing.test.mjs,scripts/smoke.mjs, andscripts/smoke-ens.sh.Testing
npm testwhich executed the unit suite and produced 15 passing tests and 1 failing test (boot fails fast without keys unless DEV_AUTO_KEYS=1) due to the spawned process output not meeting the test's assertion in this environment.node tests/smoke.mjswhich completed successfully and verified/health, aPOST /describe/v1.1.0execution, and a/verifyroundtrip./healthor/verifyimplementation and signer/ENS behavior was not modified; the tests above confirm the newv1.1.0verb surface is reachable by the smoke checks.Codex Task