Open
Conversation
adeebshihadeh
requested changes
Dec 15, 2025
board/drivers/can_common.h
Outdated
| if ((msg->addr == 0x348U) && (len == 8)) { | ||
| // bit 41: EV running, bit 42: ICE running | ||
| ignition_can = (msg->data[5] & 0x6U) != 0U; | ||
| ignition_can_cnt = 0U; |
Contributor
There was a problem hiding this comment.
does this message have a counter? ideally all new CAN ignition signals have a counter since we're seeing some collisions across brands now
Contributor
Author
There was a problem hiding this comment.
it does not unfortunately.
Contributor
There was a problem hiding this comment.
hmm is there another one we can use that has one?
Contributor
Author
There was a problem hiding this comment.
I will check, this one works with all PSA models I have seen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CAN ignition for PSA vehicles.
EV and ICE models use two separate bits.