Honda: Nidec COMPUTER_BRAKE_ALT safety#1895
Honda: Nidec COMPUTER_BRAKE_ALT safety#1895AravindaDP wants to merge 1 commit intocommaai:masterfrom
Conversation
- define flag - add tests - fix tx and rx hooks
|
We've decided the Clarity port isn't worth it to us to upstream - see #20268 |
|
@adeebshihadeh Noted. Just a quick question. Is decision for Clarity fork because of a) It needing this alternate safety mode and needing logic change at hondacan.py to accommodate COMPUTER_BRAKE_ALT? b) Because it needs a proxy panda gateway to copy messages from extra CAN bus? (i.e. Additional H/W requirement/different harness connector) c) Both of above requirement? d) Simply because there aren't enough Clarity users irrespective of above complexities? Is there a minimum number of users that warrants a model port being accepted? As a note I was trying my luck getting Honda Fit Hybrid JDM up streamed. Following is full details.
However complexities ends there for Honda Fit Hybrid JDM. It does not need a proxy panda gateway like Clarity. Thanks a lot for your time. |
|
C and D. The calculation in terms of difficulty to get merged here is roughly: new/custom HW > panda code > openpilot code. Requiring two or three of those means we expect to support lots of models and users. |
Safety mode for COMPUTER_BRAKE_ALT used by Honda Clarity PHEV and Honda Fit Hybrid JDM vehicles.
define flag
add tests
fix tx and rx hooks