Skip to content

Revert "ffmpeg: disable x86asm (nasm not needed for hw accel)"#70

Merged
adeebshihadeh merged 2 commits into
commaai:masterfrom
TheSecurityDev:revert-disable-x86asm
May 10, 2026
Merged

Revert "ffmpeg: disable x86asm (nasm not needed for hw accel)"#70
adeebshihadeh merged 2 commits into
commaai:masterfrom
TheSecurityDev:revert-disable-x86asm

Conversation

@TheSecurityDev
Copy link
Copy Markdown
Contributor

This reverts commit 0fc2d13.

This caused some major bug with the recording the UI, including clips and the UI replay tool.

output.mp4

Copilot AI review requested due to automatic review settings April 7, 2026 21:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the prior FFmpeg build configuration that disabled x86 assembly optimizations, restoring the default x86asm behavior to address recording/UI capture regressions.

Changes:

  • Removed --disable-x86asm from the FFmpeg ./configure flags to re-enable x86 assembly paths.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TheSecurityDev TheSecurityDev marked this pull request as draft April 7, 2026 21:48
@TheSecurityDev TheSecurityDev force-pushed the revert-disable-x86asm branch from 18d5149 to 2f5b981 Compare April 7, 2026 21:48
@TheSecurityDev TheSecurityDev reopened this Apr 7, 2026
@TheSecurityDev TheSecurityDev marked this pull request as ready for review April 7, 2026 21:51
@adeebshihadeh adeebshihadeh merged commit 62b54eb into commaai:master May 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants