Conversation
Allow to speficy any URL by discovery_service_url option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes following updates.
And I will create a new PR for bumping version soon. Then I will upload new version.
Change discovery URL
By this change, this module uses new discovery URL
https://www.googleapis.com/discovery/v1/apis/{api}/{apiVersion}/resthttps://{api}.googleapis.com/$discovery/rest?version={apiVersion}Some APIs are still using previous URL though, it is converted by detecting services in
Google::API::Client::_is_v1_discovery_url.discovery_service_url option
You can specify discovery URL by using discovery_service_url option like below. (Following code does not work. Because the discovery URL is dummy.)
Other
Thanks
Thanks to @robhammond and @7mho7. Their PRs, #26 and #27, helped me to create this PR.