[codex] Fix hook flush overhead#26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
count_tokensresponses as errors so the detached measurement pass does not cache zero-token anchors from auth/rate-limit/error payloads.Review notes
Recent changes added useful billing and attribution detail, but the hook hot path had one avoidable cost:
flushalways calledbuildContextSnapshot, even for tool-only batches. That helper reads the full transcript and hits memory/agent/skill/tool extractors; doing that during ordinary tool hook flushes slows Claude Code without adding metadata because only spans with usage receive the snapshot.I did not include the local
bin/opik-logger-darwin-arm64modification in this PR; it was already dirty before the source edits and looks like a local build artifact.Validation
go test ./...go vet ./...git diff --check