Add Data-Layer Helpers to comet-common#6
Merged
Conversation
9dd8077 to
5c1eabf
Compare
…esets (Bitnami pattern)
5c1eabf to
9930848
Compare
…arams (host, port, token, user, ssl, db, sslParams) and builds the URL
CRThaze
reviewed
Mar 3, 2026
CRThaze
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a set of new Helm template helpers and schema definitions to standardize and simplify configuration for MySQL, Redis, and S3 across charts. It adds reusable helper templates for each service, updates the schema to support these new options, and bumps the chart version to reflect these enhancements.
New configuration helpers and schema support:
MySQL helpers and schema:
templates/_mysql.tplwith a comprehensive set of helpers for MySQL connection, admin credentials, SSL, AWS/IAM, connection pooling, and replicated endpoints. Also includes connection URL builders for both primary and read-only connections.values.schema.jsonto define the new.Values.global.mysqlobject, documenting all supported MySQL configuration options, including replication and client certificate support.Redis helpers and schema:
templates/_redis.tplwith helpers for retrieving Redis configuration values and generating Redis URLs, supporting flexible parameterization (database selection, SSL, username/password, etc.).values.schema.jsonto define the new.Values.global.redisobject, documenting supported Redis configuration options.S3 helpers and schema:
templates/_s3.tplwith helpers for S3 configuration value retrieval and region-aware S3 endpoint normalization.values.schema.jsonto define the new.Values.global.s3object, documenting S3 and object storage configuration options.General Helm improvements:
"IfNotPresent".0.1.0to0.2.0inChart.yamlto reflect these changes.