-
Notifications
You must be signed in to change notification settings - Fork 5
refactor: separate packages for Vue, React and Nuxt #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
5a7b95e
refactor: separate packages for vue, react and nuxt
farnabaz aabdf41
chore: updates tests
farnabaz f8ee0bb
update docs
farnabaz 3917a08
Merge branch 'main' into refactor/separate-packages
atinux 1142716
docs: improvement
atinux 1e05d65
update docs
farnabaz f8b8aa6
Merge branch 'main' into refactor/separate-packages
farnabaz b499ef6
Update 1.installation.md
atinux b706d66
Update 1.installation.md
atinux 9bfbd8d
chore: fix import
atinux 9673212
Merge branch 'main' into refactor/separate-packages
atinux 1732142
Merge branch 'main' into refactor/separate-packages
farnabaz 7051a73
refactor: move plugins components to renderer packages
farnabaz c87f342
lint: fix
farnabaz 1cdb1cd
fix: stub
farnabaz 05ba321
up
farnabaz 9f188a2
chore: update build command
farnabaz 2348fc3
Merge branch 'main' into refactor/separate-packages
farnabaz 7e3cf03
up
farnabaz 2e0d031
test: disable browser in ci
farnabaz de0ed87
up
farnabaz 1a4cdde
test: update vitest cofnig
farnabaz a0e3531
chore: update plugins structure
farnabaz 01bbab2
update packages and docs
farnabaz 8dc1a43
Merge branch 'main' into refactor/separate-packages
farnabaz 5b1b5fc
fix: react components
farnabaz f85da8f
up
farnabaz 5286d18
up
farnabaz 3f02706
up
farnabaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems wrong, as the
defineComarkComponentfn is still used belowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm noticing now that the plugins also have the same problem where they export multiple frameworks' components / are bundled (meaning lots of potential issues with package deduplication in end user apps) -- I wonder if the plugins should only export the actual Comark plugin (for example,
comarkMermaid), and the framework packages (@comark/svelte,@comark/vue, etc) should re-export them:That way the vast majority of users still only have one package to install, and treeshaking will still work great...