PR: Implement support to generate the "Rösch-MacAdam" colour solid hue lines.#777
Merged
PR: Implement support to generate the "Rösch-MacAdam" colour solid hue lines.#777
Conversation
532a6f9 to
b5961d7
Compare
…rate_pulse_waves" definition.
…waves" definition can be easily filtered.
8435e69 to
d1cca65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for the argument I described in @scooperly's Sketches of Hue thread on ACEScentral.
I remembered about it only because I started to look at @gutenzwerg's work in #768. Note that #768 is different in the sense that the Optimal Colour Stimuli are computed for a given luminance level.
Sean produced a not-insignificant amount of work and our implementation of the CIE XYZ outer surface could/should have covered that with a few minor changes, namely the pulse waves ordering.
I will merge as soon as tests pass and put the above code in the How-To Guide and on ACEScentral.