NOJIRA: fixed integration test #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Oh nice catch. I always mean to run the integration tests before I make a PR but honestly they're slow and kind of a pain to setup so I end up skipping it. I'll run them shortly and provide the setup instructions (+ add them to the wiki somewhere). |
mikejritter
approved these changes
Jan 8, 2026
Contributor
mikejritter
left a comment
mikejritter
left a comment
There was a problem hiding this comment.
Verified all tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
It fixes the failing test of the nightly build job: https://github.com/collectionspace/cspace-nightly-build/actions/runs/20772692347/job/59651871149
Why are we doing this? (with JIRA link)
The
altTextwas added in the response in the scope of this PR: #489. The test has been updated accordingly.How should this be tested? Do these changes have associated tests?
I tried testing by running
mvn test -Dtest=XmlReplayMasterTestbut I get 401 unauthorised errors and I cannot find out why... @mikejritter please try running the tests locally and if you have any clue why it is failing on my side, please let me know :-)Dependencies for merging? Releasing to production?
no dependencies
Has the application documentation been updated for these changes?
no need
Did someone actually run this code to verify it works?
@spirosdi tried running tests locally but keeps getting 401 errors.