DRYD-1923: Accessibility > Resolve orphaned form labels (Criteria 3.3.2)#351
Merged
Conversation
mikejritter
approved these changes
May 18, 2026
Contributor
mikejritter
left a comment
There was a problem hiding this comment.
Ran this locally and see:
- Compound inputs switched from dev to fieldsets
- Legends applied to fieldsets
- New label ids/htmlFor being applied to labels
Also checked that tests are passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
inputHelper.buildInputIdthat builds a unique id per field based onrecordType, formName, path. F.e for theidentificationNumberof the default form, the built id iscspace-collectionobject-default-document-ns2_collectionobjects_common-objectNumber. Thecspaceprefix is also used in css classes and its purpose is to isolate the namespace.Field,InputTable,*HierarchyEditorfor setting inputidand labelhtmlFor.Why are we doing this? (with JIRA link)
In the edit-record view there are a lot of orphaned labels (labels not associated to an input). The solution is to add a
htmlForlabel attribute pointing to a newly added inputid. This task is only about fixing the orphaned labels. The missing labels, missing legend issues will be resolved in other tasks.How should this be tested? Do these changes have associated tests?
"cspace-input": "file:../cspace-input.js". But there should also be other ways to set this up (like using symlink).Dependencies for merging? Releasing to production?
Depends on cspace-input PR: collectionspace/cspace-input.js#25. Please merge the PR after the cspace-input PR is merged, the new npmjs version is published and the cspace-ui package.json is updated accordingly.
Has the application documentation been updated for these changes?
Updated Changelog
Did someone actually run this code to verify it works?
@spirosdi ran it locally
Have any new accessibility violations been handled?
No new violations