Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby-version: ['3.3', '3.2', '3.1', '3.0']
ruby-version: ["4.0", "3.3", "3.2", "3.1", "3.0"]
steps:
- name: Checkout code
uses: actions/checkout@v3
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@
/tmp/
collectionobject.rb
coverage
Gemfile.lock
2 changes: 2 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
inherit_gem:
standard: config/base.yml
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.6
4.0.1
2 changes: 1 addition & 1 deletion .standard.yml
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ruby_version: 3.0
ruby_version: 4.0
126 changes: 0 additions & 126 deletions Gemfile.lock

This file was deleted.

11 changes: 1 addition & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,7 @@ bundle exec rake

## Releasing

```bash
gem install gem-release
# https://github.com/svenfuchs/gem-release#gem-bump
gem bump --version $VERSION
# i.e.
gem bump --version minor --pretend # dryrun
gem bump --version minor # do it for real
bundle # update gem version in Gemfile.lock
# PR and merge will publish new version
```
Create a pull request that updates `./lib/collectionspace/client/version.rb`. After it is merged a release will be built and published in RubyGems and a tag will be created and pushed to GitHub.

## Contributing

Expand Down
2 changes: 2 additions & 0 deletions collectionspace-client.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,11 @@ Gem::Specification.new do |spec|
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
spec.require_paths = ["lib"]

spec.add_dependency "base64"
spec.add_dependency "httparty"
spec.add_dependency "json"
spec.add_dependency "nokogiri"
spec.add_dependency "ostruct"

spec.add_development_dependency "awesome_print"
spec.add_development_dependency "bundler"
Expand Down
1 change: 1 addition & 0 deletions lib/collectionspace/client/client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ module CollectionSpace
# CollectionSpace client
class Client
include Helpers

attr_reader :config

def initialize(config = Configuration.new)
Expand Down
1 change: 1 addition & 0 deletions lib/collectionspace/client/request.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ module CollectionSpace
# CollectionSpace request
class Request
include HTTParty

attr_reader :config, :headers, :method, :path, :options

def default_headers(method = :get)
Expand Down
2 changes: 1 addition & 1 deletion spec/collectionspace/ui_version_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
expect(result.failure?).to be true
expect(result.message).to start_with(
"Failed to open TCP connection to " \
"anthor.collectionspace.org:443 (getaddrinfo: "
"anthor.collectionspace.org:443 (getaddrinfo"
)
expect(result.joined).to be_nil
end
Expand Down