Update type in test for upcoming intersection equality behavior change#3910
Closed
MichaelMitchell-at wants to merge 1 commit intocolinhacks:mainfrom
Closed
Conversation
✅ Deploy Preview for guileless-rolypoly-866f8a ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
4 tasks
Owner
|
Closing this out because this PR targets Zod 3, which is now in maintenance mode. Thanks for the contribution, and apologies for not getting to it sooner. It was difficult to merge or cherry-pick PRs created during active Zod 4 development. If this fixes a bug, please check whether it still reproduces on the latest version of Zod 4. If this adds a feature, please check whether it is still missing in Zod 4. If so, feel free to open a new PR against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If microsoft/TypeScript#60726 is merged, then the type
{ name: string } & { [z.BRAND]: { superschema: true } }will become identical to{ name: string ; [z.BRAND]: { superschema: true } }, which is not identical to{ name: string } & z.BRAND<'superschema'>becausez.BRAND<'superschema'>cannot be "trivially merged" into the object literal type.