Feature add character search ability#10
Open
tsalopek wants to merge 29 commits intocoleestrin:mainfrom
Open
Conversation
feat: merc filters and prev/next character navigation
feat: account tracking
feat: snapshots
feat: account queue
feat: leaderboards
…er search in context of other searches.
Contributor
Author
|
This PR addresses: |
coleestrin
reviewed
Feb 1, 2026
Owner
There was a problem hiding this comment.
Could you remove this from the PR?
coleestrin
reviewed
Feb 1, 2026
| characters | ||
| </Text> | ||
| )} | ||
| <Flex align="center" gap="md"> |
Owner
There was a problem hiding this comment.
I think it would look nicer if the search bar was floated to the far right, so that its directly to the left of the settings button
Owner
There was a problem hiding this comment.
We'd also want to debounce this to avoid api requests as they're actively typing characters
coleestrin
reviewed
Feb 1, 2026
| //if (isLoading.current) return; | ||
|
|
||
| isLoading.current = true; | ||
| const requestId = ++requestIdRef.current; |
Owner
There was a problem hiding this comment.
Whats the purpose of adding the requestId tracking?
coleestrin
reviewed
Feb 1, 2026
| filter.requiredMercItems = (mercItems as string).split(","); | ||
| } | ||
| if (query && (query as string).trim().length >= 3) { | ||
| filter.searchQuery = (query as string).trim(); |
Owner
There was a problem hiding this comment.
Were there database changes you forgot to commit? I don't see any mention of searchQuery in api/src/database/postgres/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the ability to perform character name searches in and out of context of other searches from the left-hand search tools.
Search occurs after 3 characters have been input. This one may be a bit heavier on the backend, cache hits appear to be occurring as expected, however, a double check on this would certainly be appreciated as I'm new to the repo.