Better exception handling in tests#322
Conversation
rotu
commented
Mar 14, 2020
- Don't continue with testing if an extension crashes
- Use logger.exception to format current traceback in an error
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
==========================================
+ Coverage 79.61% 79.65% +0.03%
==========================================
Files 55 55
Lines 3209 3209
Branches 534 534
==========================================
+ Hits 2555 2556 +1
+ Misses 607 606 -1
Partials 47 47
Continue to review full report at Codecov.
|
(As mentioned a few times to you already) Please consider creating separate pull requests for orthogonal changes - simply because each can be reviewed and iterated on independently. Regarding the functional change: a very important design choice / feature of colcon is that a single extension (which can be provided by any package) does rarely result in a fatal error of the tool. In as many cases as possible |