Conversation
- GitHub App install URL を API (GET /app) から動的取得+メモリキャッシュ - auth-client.ts の baseURL ハードコード除去(相対パスで動作) - GitHub App settings URL のパス修正 (/orgs/ → /organizations/) - vite.config.ts に ngrok ホスト許可を追加 - dotenv チェックに GITHUB_CLIENT_ID/SECRET を追加(GOOGLE系を修正) - process.server.ts に scopes セマンティクスのコメント追加 - README を英語統一、PAT/GitHub App の2方式構成に整理 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughGitHubアプリのOAuth認証とWebhook統合を導入するため、環境変数スキーマをGoogle OAuthからGitHub OAuthに変更し、GitHub Appスラッグを動的に取得する機能を追加しました。既存のプロセスにはスコープが空の場合の早期リターンガード処理が追加されています。 Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant IntegrationRoute as Integration Route<br/>(Loader/Action)
participant AppSlugService as GitHub App Slug<br/>Service
participant GitHubAPI as GitHub REST API
User->>IntegrationRoute: リクエスト(インストール)
activate IntegrationRoute
IntegrationRoute->>AppSlugService: getGithubAppSlug() 呼び出し
activate AppSlugService
AppSlugService->>GitHubAPI: GET /app(アプリ認証)
activate GitHubAPI
GitHubAPI-->>AppSlugService: { slug: "upflow-team" }
deactivate GitHubAPI
AppSlugService->>AppSlugService: キャッシュに保存
AppSlugService-->>IntegrationRoute: slug を返却
deactivate AppSlugService
IntegrationRoute->>IntegrationRoute: 動的URL構築<br/>https://github.com/apps/{slug}/installations/new
alt installGithubApp intent
IntegrationRoute-->>User: リダイレクト
else copyInstallUrl intent
IntegrationRoute-->>User: installUrl をレスポンス返却
end
deactivate IntegrationRoute
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /appAPI with in-memory cachebaseURLin auth-client.ts — use relative paths for all environments/orgs/→/organizations/)allowedHostsfor local webhook testingGOOGLE_CLIENT_ID/SECRET→GITHUB_CLIENT_ID/SECRETscopessemantics comment toprocess.server.tsTest plan
pnpm validatepassesGITHUB_APP_ID)baseURLin auth-client🤖 Generated with Claude Code
Summary by CodeRabbit
リリースノート
ドキュメント
新機能