-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Webhook によるリアルタイム PR 更新 #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
17c6c34
feat: Webhook によるリアルタイム PR 更新 (#255)
coji 0ec5838
fix: takt cursor provider を full permission に修正
coji 6a84f99
refactor: simplify レビュー指摘を反映
coji 8f7c932
fix: CodeRabbit レビュー指摘を反映
coji 1d13ca5
fix: pullId を Number() で変換して prNumbers スキーマに適合させる
coji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| .claude/ | ||
| pnpm-lock.yaml | ||
| app/services/type.ts | ||
| app/services/tenant-type.ts | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,87 @@ | ||
| tasks: [] | ||
| tasks: | ||
| - worktree: false | ||
| branch: feat/webhook-realtime-pr-update | ||
| piece: implement-step | ||
| issue: 255 | ||
| auto_pr: false | ||
| draft_pr: false | ||
| name: webhook-realtime-pr-update-impl | ||
| status: failed | ||
| slug: 20260331-113806-wh255 | ||
| task_dir: .takt/tasks/20260331-113806-wh255 | ||
| created_at: 2026-03-31T11:38:06.000Z | ||
| started_at: 2026-03-31T11:41:07.279Z | ||
| completed_at: 2026-03-31T12:09:48.132Z | ||
| owner_pid: null | ||
| failure: | ||
| movement: fix | ||
| error: "Movement execution failed: All parallel sub-movements failed: | ||
| arch-review: Report phase failed for architect-review.md: You've hit | ||
| your usage limit. Upgrade to Pro (https://chatgpt.com/explore/pro), | ||
| visit https://chatgpt.com/codex/settings/usage to purchase more credits | ||
| or try again at Apr 3rd, 2026 11:33 PM.; supervise: Report phase failed | ||
| for supervisor-validation.md: You've hit your usage limit. Upgrade to | ||
| Pro (https://chatgpt.com/explore/pro), visit | ||
| https://chatgpt.com/codex/settings/usage to purchase more credits or try | ||
| again at Apr 3rd, 2026 11:33 PM." | ||
| last_message: >- | ||
| レビュー報告を確認し、指摘を修正します。 | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| レビュー指摘を修正します: PR オブジェクトの直接ミューテーションと、リポジトリスコープ付き refresh 時の full-org | ||
| `process` 誤起動。 | ||
|
|
||
|
|
||
|
|
||
| PR オブジェクトの非ミュータブル化と、リポジトリスコープ付き refresh 時の full-org `process` | ||
| 誤判定を修正します。ヘルパーと回帰テストを追加します。 | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
| 対応内容は次のとおりです。 | ||
|
|
||
|
|
||
| ## 1. PR オブジェクトの直接ミューテーション(ARCH-NEW-direct-pr-files-mutation / | ||
| VAL-NEW-direct-mutation) | ||
|
|
||
| - **`crawl.server.ts`**: `prMetadata.files = files` をやめ、`const prForSave | ||
| = { ...prMetadata, files }` を `savePrData` に渡すように変更。 | ||
|
|
||
| - **`$pull/index.tsx`**: 同様に `const prForSave = { ...prMetadata, files | ||
| }` を使用。 | ||
|
|
||
| - **`backfill-repo.ts`**: `pr.files = files` をやめ、`const prWithFiles = { | ||
| ...pr, files }` を `updatePrMetadata` に渡すように変更。 | ||
|
|
||
|
|
||
| ## 2. リポジトリ指定付き refresh で full-org `process` が走る問題(carry-over | ||
| ARCH-NEW-crawl-scoped-handoff) | ||
|
|
||
| - **`crawl-process-handoff.server.ts`** | ||
| を追加し、`shouldTriggerFullOrgProcessJob` で | ||
| 「`refresh` かつ **`repositoryId` なし** かつ **PR 番号の指定なし**」のときだけ org 全体の `process` と判定。 | ||
| - **`crawl.server.ts`**: 従来の `input.refresh && !input.prNumbers` | ||
| を、この関数呼び出しに置き換え。`--repository … --refresh` のときは常に scoped | ||
| 側(`updatedPrNumbers` 由来の `scopes`)へ。 | ||
|
|
||
|
|
||
| ## 3. 回帰テスト | ||
|
|
||
| - **`crawl-process-handoff.server.test.ts`**: 上記判定のユニットテストを追加(リポジトリ付き | ||
| refresh が full-org にならないこと等)。 | ||
|
|
||
|
|
||
| `pnpm validate` は問題なく完了しています(テスト 310 件)。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.