Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ jobs:

- name: Test
run: mvn -B test

- name: Javadoc
run: mvn -B javadoc:javadoc
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## [1.10.1] - 2026-JUN-23

### Fixed

- **Maven Central publish**: Javadoc generation failed on model comments containing `>`, `>=`, or `->` from OpenAPI descriptions (e.g. margin threshold comparisons, call priority ordering). Disabled doclint HTML checks in `maven-javadoc-plugin` so generated comments stay human-readable while Javadoc still builds for release.
- **CI**: PR workflow runs `mvn javadoc:javadoc` so Javadoc failures are caught before release.

## [1.10.0] - 2026-JUN-17

### Added
Expand Down
5 changes: 4 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<description>Sample Java SDK for the Coinbase Prime REST APIs</description>
<groupId>com.coinbase.prime</groupId>
<url>https://github.com/coinbase/prime-sdk-java</url>
<version>1.10.0</version>
<version>1.10.1</version>
<licenses>
<license>
<name>Apache License, Version 2.0</name>
Expand Down Expand Up @@ -96,6 +96,9 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.7.0</version>
<configuration>
<doclint>none</doclint>
</configuration>
<executions>
<execution>
<id>attach-javadocs</id>
Expand Down
12 changes: 12 additions & 0 deletions tools/model-generator/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,13 @@
<artifactId>slf4j-simple</artifactId>
<version>2.0.9</version>
</dependency>

<dependency>
<groupId>org.junit.jupiter</groupId>
<artifactId>junit-jupiter</artifactId>
<version>5.10.0</version>
<scope>test</scope>
</dependency>
</dependencies>

<build>
Expand All @@ -88,6 +95,11 @@
<target>11</target>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>3.0.0-M5</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
/*
* Copyright 2026-present Coinbase Global, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package com.coinbase.tools.modelgenerator;

import static org.junit.jupiter.api.Assertions.assertEquals;

import org.junit.jupiter.api.Test;

class PostProcessorJavadocTest {

@Test
void decodeHtmlEntities_decodesCommonEntities() {
assertEquals(
"aged > urgent > standard > debit",
PostProcessor.decodeHtmlEntities("aged &gt; urgent &gt; standard &gt; debit"));
assertEquals(
"EQ / MR >= threshold_value",
PostProcessor.decodeHtmlEntities("EQ / MR &gt;= threshold_value"));
assertEquals(
"(tier_a, tier_b) -> rate",
PostProcessor.decodeHtmlEntities("(tier_a, tier_b) -&gt; rate"));
assertEquals(
"margin excess is > 0",
PostProcessor.decodeHtmlEntities("margin excess is &gt; 0"));
}

@Test
void decodeHtmlEntities_leavesPlainTextUnchanged() {
assertEquals(
"aged > urgent > standard > debit",
PostProcessor.decodeHtmlEntities("aged > urgent > standard > debit"));
assertEquals(
"EQ / MR >= threshold_value",
PostProcessor.decodeHtmlEntities("EQ / MR >= threshold_value"));
}

@Test
void decodeHtmlEntities_decodesAcrossFullFileContent() {
String input =
"public class Foo {\n"
+ " /**\n"
+ " * aged &gt; urgent &gt; standard &gt; debit.\n"
+ " */\n"
+ " private String bar;\n"
+ "}\n";

String expected =
"public class Foo {\n"
+ " /**\n"
+ " * aged > urgent > standard > debit.\n"
+ " */\n"
+ " private String bar;\n"
+ "}\n";

assertEquals(expected, PostProcessor.decodeHtmlEntities(input));
}
}
Loading