Skip to content

[chore] Hot Fix Examples Async/Await Execution #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
John-peterson-coinbase wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[chore] Hot Fix Examples Async/Await Execution #99

John-peterson-coinbase wants to merge 1 commit into from

Conversation

@John-peterson-coinbase
Copy link
Contributor

@John-peterson-coinbase John-peterson-coinbase commented Jul 13, 2024

What changed? Why?

  • Our examples define async functions. Currently, they are not awaited which can result in the execution of the script completed before the promise resolves
  • The examples are updated to properly handle the example function calls

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Aug 18, 2024

Review Error for melissamforbs @ 2024-08-18 06:18:16 UTC
User must have write permissions to review

@cb-heimdall
Copy link

cb-heimdall commented Aug 18, 2024

Review Error for melissamforbs @ 2024-08-18 06:18:37 UTC
User must have write permissions to review

@cb-heimdall
Copy link

cb-heimdall commented Sep 10, 2024

Review Error for melissamforbs @ 2024-09-10 12:00:14 UTC
User must have write permissions to review

@cb-heimdall
Copy link

cb-heimdall commented Oct 1, 2024

Review Error for melissamforbs @ 2024-10-01 16:18:55 UTC
User must have write permissions to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erdimaden erdimaden Awaiting requested review from erdimaden

@alex-stone alex-stone Awaiting requested review from alex-stone

@jazz-cb jazz-cb Awaiting requested review from jazz-cb

1 more reviewer

@melissamforbs melissamforbs melissamforbs approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@John-peterson-coinbase @cb-heimdall @melissamforbs