Skip to content

Fix empty LZ4 compression streams #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsweeting merged 1 commit into from
Jun 25, 2025
Merged

Fix empty LZ4 compression streams #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/z_stream/lz4.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,11 @@ defmodule ZStream.LZ4 do
{:erlang.iolist_to_iovec(elem), ref}
end

defp do_compress_end({:start, ref}) do
finish = :lz4f.compress_end(ref)
{:erlang.iolist_to_iovec(finish), ref}
end

defp do_compress_end(ref) do
finish = :lz4f.compress_end(ref)
{:erlang.iolist_to_iovec(finish), ref}
Expand Down
11 changes: 11 additions & 0 deletions test/z_stream/lz4_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ defmodule ZStream.LZ4Test do
stream = ZStream.compress(data, LZ4)

assert :ok = Stream.run(stream)

data = Enum.take(data, 0)
stream = ZStream.compress(data, LZ4)

assert :ok = Stream.run(stream)
end

test "decompress" do
Expand All @@ -18,5 +23,11 @@ defmodule ZStream.LZ4Test do
stream = ZStream.decompress(stream, LZ4)

assert Enum.into(stream, "") == Enum.into(data, "")

data = Enum.take(data, 0)
stream = ZStream.compress(data, LZ4)
stream = ZStream.decompress(stream, LZ4)

assert Enum.into(stream, "") == ""
end
end
11 changes: 11 additions & 0 deletions test/z_stream/zstandard_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ defmodule ZStream.ZstandardTest do
stream = ZStream.compress(data, Zstandard)

assert :ok = Stream.run(stream)

data = Enum.take(data, 0)
stream = ZStream.compress(data, Zstandard)

assert :ok = Stream.run(stream)
end

test "decompress" do
Expand All @@ -18,5 +23,11 @@ defmodule ZStream.ZstandardTest do
stream = ZStream.decompress(stream, Zstandard)

assert Enum.into(stream, "") == Enum.into(data, "")

data = Enum.take(data, 0)
stream = ZStream.compress(data, Zstandard)
stream = ZStream.decompress(stream, Zstandard)

assert Enum.into(stream, "") == ""
end
end