[CDF-27499] 🏦 Deploy v2 teriminal output. #2742
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request significantly improves the terminal output for the deploy v2 command, enhancing user experience with more structured and informative summaries using rich. It also introduces robust validation for the target CDF project. My review identified a critical bug in how deployment results are aggregated, which could misinform the user about their ability to deploy. Additionally, a high-severity issue was found where warnings were being generated inefficiently. Addressing these points will ensure the new functionality is both robust and correct.
a772415 to
997f2b5
Compare
997f2b5 to
fb987d4
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2742 +/- ##
==========================================
- Coverage 85.61% 85.45% -0.17%
==========================================
Files 447 447
Lines 38330 38406 +76
==========================================
+ Hits 32817 32820 +3
- Misses 5513 5586 +73
🚀 New features to boost your workflow:
|


Description
This PR has the terminal output for deploy v2
Dry run
Deploy
And for the non-happy cases
Bump