Skip to content

[CDF-27499] 🏦 Deploy v2 teriminal output. #2742

Merged
doctrino merged 18 commits intomainfrom
deploy-v2-terminal
Mar 23, 2026
Merged

[CDF-27499] 🏦 Deploy v2 teriminal output. #2742
doctrino merged 18 commits intomainfrom
deploy-v2-terminal

Conversation

@doctrino
Copy link
Copy Markdown
Contributor

@doctrino doctrino commented Mar 19, 2026

Description

This PR has the terminal output for deploy v2

Dry run

image

Deploy

image

And for the non-happy cases

image image

Bump

  • Patch
  • Skip

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@doctrino
Copy link
Copy Markdown
Contributor Author

/gemini review

@doctrino doctrino marked this pull request as ready for review March 19, 2026 10:00
@doctrino doctrino requested review from a team as code owners March 19, 2026 10:00
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the terminal output for the deploy v2 command, enhancing user experience with more structured and informative summaries using rich. It also introduces robust validation for the target CDF project. My review identified a critical bug in how deployment results are aggregated, which could misinform the user about their ability to deploy. Additionally, a high-severity issue was found where warnings were being generated inefficiently. Addressing these points will ensure the new functionality is both robust and correct.

Comment thread cognite_toolkit/_cdf_tk/commands/deploy_v2/command.py Outdated
Comment thread cognite_toolkit/_cdf_tk/commands/deploy_v2/command.py Outdated
@doctrino doctrino force-pushed the deploy-v2-terminal branch from a772415 to 997f2b5 Compare March 19, 2026 10:08
@doctrino doctrino force-pushed the deploy-v2-terminal branch from 997f2b5 to fb987d4 Compare March 19, 2026 10:11
@doctrino doctrino enabled auto-merge (squash) March 19, 2026 10:14
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
38406 32823 85% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
cognite_toolkit/_cdf_tk/commands/deploy_v2/command.py 57% 🟢
TOTAL 57% 🟢

updated for commit: a132a6c by action🐍

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 13.82114% with 106 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.45%. Comparing base (27a7a1b) to head (d683fc0).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...nite_toolkit/_cdf_tk/commands/deploy_v2/command.py 13.82% 106 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2742      +/-   ##
==========================================
- Coverage   85.61%   85.45%   -0.17%     
==========================================
  Files         447      447              
  Lines       38330    38406      +76     
==========================================
+ Hits        32817    32820       +3     
- Misses       5513     5586      +73     
Files with missing lines Coverage Δ
...nite_toolkit/_cdf_tk/commands/deploy_v2/command.py 57.33% <13.82%> (-9.78%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@doctrino
Copy link
Copy Markdown
Contributor Author

And for the non-happy cases

image image

Comment thread cognite_toolkit/_cdf_tk/commands/deploy_v2/command.py Outdated
@doctrino doctrino requested a review from ronpal March 23, 2026 08:09
@doctrino doctrino merged commit ebb84f3 into main Mar 23, 2026
15 checks passed
@doctrino doctrino deleted the deploy-v2-terminal branch March 23, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants