-
Notifications
You must be signed in to change notification settings - Fork 0
Encrypted Notes Support #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuval-po
wants to merge
27
commits into
develop
Choose a base branch
from
cryptocore
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This P.R introduces basic support for note encryption
NOTE: Encryption is in the ALPHA stage and should not be depended upon or deployed to production as-is
Data loss is a real possibility
Encryption is a custom, zero-knowledge scheme (nicknamed 'fractured key encryption') where the server provides part of the encryption parameters (Salts & KEKs) and the client uses them to both construct and encrypt its own encryption keys.
Once encrypted, the server cannot decrypt the data.
On the flip side, the client cannot decrypt the data without the server meaning the scheme also resists 'cold' attacks on the encrypted data, even given the original password.
More on the encryption mechanism in a separate article.
Additional changes included in the P.R:
Noterelated operationsdebouncing(viaNoteWrapper- a proxy-like class over rawNotes)