-
-
Notifications
You must be signed in to change notification settings - Fork 4
Update Python & Django version support #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR attempts to update Python and Django version support by adding Python 3.14 and Django 6.0 while dropping Django 5.1. However, the PR contains critical issues as both Python 3.14 and Django 6.0 have not been officially released yet and are not available for use.
Key Changes:
- Addition of Python 3.14 support in package classifiers and CI matrix
- Addition of Django 6.0 support in package classifiers and CI matrix
- Removal of Django 5.1 from supported versions
- Simplified Django version format in CI workflow (from "4.2.0" to "4.2")
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pyproject.toml | Added Python 3.14 and Django 6.0 classifiers, removed Django 5.1 classifier |
| .github/workflows/ci.yml | Added Python 3.14 and Django 6.0 to test matrix, removed Django 5.1, simplified version format |
Critical Issues Found:
- Python 3.14 has not been released yet and is not available in GitHub Actions or for production use
- Django 6.0 has not been released yet and is not available on PyPI
- These additions will cause immediate CI failures and prevent the package from being properly tested
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 99.69% 93.27% -6.43%
==========================================
Files 21 21
Lines 332 342 +10
==========================================
- Hits 331 319 -12
- Misses 1 23 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4f18bf6 to
1254c6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Add Python 3.14 * Add Django 6.0 * Add Wagtail 7.2 * Drop Django 5.1 (EoL)
Uh oh!
There was an error while loading. Please reload this page.