Skip to content

Some Minor Issues Resolved #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vasudev13 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Some Minor Issues Resolved #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added .idea/caches/build_file_checksums.ser
View file
Open in desktop
Binary file not shown.
29 changes: 29 additions & 0 deletions .idea/codeStyles/Project.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 1 addition & 11 deletions .idea/misc.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions .idea/modules.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/vcs.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions app/src/main/java/com/condingblocks/multicopy/views/Custom/MultiCopy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ public void onClick(View v) {
AdRequest adRequest = new AdRequest.Builder().build();
adView.loadAd(adRequest);



return view;
}

Expand Down
35 changes: 23 additions & 12 deletions app/src/main/java/com/condingblocks/multicopy/views/Fragments/NotesFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,24 +113,35 @@ private void refreshData(){
public void onNotesEdit(String notes, int position) {
if (notesFragment_LOG)
Log.d(TAG, "onNotesEdit: " + notes);
Realm realm = Realm.getDefaultInstance();
realm.beginTransaction();
notesList.get(position).setNote(notes);
realm.copyToRealm(notesList.get(position));
notesAdapter.notifyItemChanged(position);
realm.commitTransaction();

//vasudev13: Avoiding editing of existing note to blank note

if(!notes.isEmpty()) {
Realm realm = Realm.getDefaultInstance();
realm.beginTransaction();
notesList.get(position).setNote(notes);
realm.copyToRealm(notesList.get(position));
notesAdapter.notifyItemChanged(position);
realm.commitTransaction();
}
}

@Override
public void onNewNote(String note,String createdAt) {
if (notesFragment_LOG)
Log.d(TAG, "onNewNote: " + note + " " + createdAt);
Realm realm = Realm.getDefaultInstance();
realm.beginTransaction();
notesList.add(new NotesModel(note,createdAt));
realm.copyToRealmOrUpdate(notesList);
realm.commitTransaction();
notesAdapter.notifyDataSetChanged();

//vasudev13: Avoiding addition of blank notes to list

if(!note.isEmpty() && !createdAt.isEmpty()) {
Realm realm = Realm.getDefaultInstance();
realm.beginTransaction();
notesList.add(new NotesModel(note, createdAt));
realm.copyToRealmOrUpdate(notesList);
realm.commitTransaction();
notesAdapter.notifyDataSetChanged();
}
Log.d("onNewNote",notesList.size()+"");
}

//deletefrom Notes List
Expand Down
5 changes: 3 additions & 2 deletions app/src/main/res/layout/fragment_notes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
<!-- vasudev13: used coordinator layout to avoid overlap of fab and snackbar-->
<android.support.design.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:layout_width="match_parent"
android:layout_height="match_parent"
Expand All @@ -22,4 +23,4 @@
app:borderWidth="0dp"
/>

</FrameLayout>
</android.support.design.widget.CoordinatorLayout>