Skip to content

Remove matrices from the ci-cd pipeline's Rubocop job #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArtOfCode- merged 2 commits into from
Aug 4, 2025
Merged

Remove matrices from the ci-cd pipeline's Rubocop job #1739

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc452da
removed matrices from the ci-cd pipeline's Rubocop action
Oaphi Aug 4, 2025
b571453
Merge branch 'develop' into 0valt/ci
Oaphi Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,13 @@ on:

env:
RAILS_ENV: test
RUBY_VERSION: 3.2

jobs:
rubocop:
name: Rubocop checking
runs-on: ubuntu-latest

strategy:
matrix:
ruby_version: [3.1, 3.2]

steps:
- name: Checkout repo
uses: actions/checkout@v3
Expand All @@ -30,7 +27,7 @@ jobs:
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby_version }}
ruby-version: ${{ env.RUBY_VERSION }}
bundler-cache: true
- run: bundle exec rubocop

Expand Down Expand Up @@ -106,7 +103,7 @@ jobs:
path: tmp/screenshots
if-no-files-found: ignore
- uses: codecov/codecov-action@v5
if: ${{ matrix.ruby_version == 3.2 && matrix.test_type == 'test' && github.actor != 'dependabot[bot]' }}
if: ${{ matrix.ruby_version == env.RUBY_VERSION && matrix.test_type == 'test' && github.actor != 'dependabot[bot]' }}
with:
directory: coverage
fail_ci_if_error: true
Expand Down