fix: admin heading spacing and button icon alignment#9
Merged
Conversation
Admin UI polish, verified in a live WordPress 7.0 install: - Main heading (.wp-puller-title) had no breathing room because WP core's `.wrap h1` (margin:0) out-specified the single-class selector. Raise specificity to `.wp-puller-wrap .wp-puller-title` and give it top/bottom margin (16px/28px), a little top padding, and a 10px gap between the icon, title, and version badge. - Dashicons inside buttons rendered with an inherited line-height (~30px) in a 16px-tall box, pushing the glyph off-center. Pin each icon's line-height to its box height (16px buttons, 28px title) so glyphs sit centered. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small admin-UI polish fixes, both verified in a live WordPress 7.0 / PHP 8.2 install with the plugin active.
Type of change
Changes
1. Main heading spacing. The
.wp-puller-titleheading had no breathing room. WordPress core's.wrap h1 { margin: 0 }(specificity 0,0,1,1) was out-specifying the plugin's single-class.wp-puller-title(0,0,1,0), so the custom margin never applied. Fixed by raising specificity to.wp-puller-wrap .wp-puller-titleand giving itmargin: 16px 0 28px, a small top padding, and a10pxgap between the icon, title text, and version badge.2. Button icon vertical alignment. Dashicons inside buttons rendered with an inherited
line-height(~30px) inside a 16px-tall box, so the glyph sat above the optical center next to the label. Fixed by pinning each icon'sline-heightto its box height (16pxfor action/field/copy buttons,28pxfor the title icon).How was this tested?
getBoundingClientRect+getComputedStyle(icon line-height now equals box height; heading margins now apply).Checklist
php -l/ no PHP touched (CSS only).wp-puller.zip(handled separately, per CONTRIBUTING).