Open
Conversation
Signed-off-by: bachgg <82871810+bachgg@users.noreply.github.com>
bachgg
force-pushed
the
bach/install-argocd
branch
from
1e382ed to
3d013d4
Compare
Signed-off-by: bachgg <82871810+bachgg@users.noreply.github.com>
Signed-off-by: bachgg <82871810+bachgg@users.noreply.github.com>
NautiluX
reviewed
Mar 6, 2026
| } | ||
|
|
||
| // Install the ArgoCD chart | ||
| func (a *ArgoCD) Install() error { |
Member
There was a problem hiding this comment.
This function looks a bit complex, did you consider splitting it up?
| } | ||
| } | ||
|
|
||
| func (a *ArgoCD) applyPostInstallResources() error { |
Member
There was a problem hiding this comment.
besides the local-cluster thing I think these should be optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oms beta install argocdto install ArgoCD helm chart with desired version, AppProject resources, secrets for ArgoCD to read manifests from git repo and helm registry--versionand if not, the latest chart version is installedTo manually test this PR:
kind create cluster./oms beta install argocd --dc-id 7 --git-password 00001112222 --registry-password 12345999kubectl get secrets/argocd-codesphere-repos-read -nargocd -ojson | jq -r ".data.password" | base64 -dkubectl get secrets/argocd-codesphere-oci-read -nargocd -ojson | jq -r ".data.password" | base64 -d