Fix: improve performance by loading snippets only on manage screen#389
Open
rami-elementor wants to merge 1 commit intocore-betafrom
Open
Fix: improve performance by loading snippets only on manage screen#389rami-elementor wants to merge 1 commit intocore-betafrom
rami-elementor wants to merge 1 commit intocore-betafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change in
Manage_Menu.phpmakessnippetsListconditional.Previously, every Manage Code Snippets page request localized the full result of
get_snippets()intowindow.CODE_SNIPPETS_MANAGE, even when displaying the Community Cloud page or the Blueprints page (in Pro).Now, it builds the common localized settings first, and only adds the full snippets payload when it's not a sub-page. As a result, it no longer loads the full result of snippets on subpages.
How does it affect different pages:
/wp-admin/admin.php?page=snippets(no change)/wp-admin/admin.php?page=snippets&subpage=blueprints(optimized)/wp-admin/admin.php?page=snippets&subpage=cloud-community(optimized)Performance benefits:
get_snippets()on the Community Cloud subpage.SELECT *from the snippets table when the snippets cache is cold.is_snippet_locked().get_fields().