Add test plan by nabilasherif · Pull Request #51 · codescalersinternships/test-tracker

nabilasherif · 2024-08-12T12:27:53Z

Description
add test plan
Changes

get plans
search for a plan
delete a plan

Related issues
#25

maayarosama · 2024-08-14T09:33:59Z

client/src/api/axios.ts

+  await AuthClient.post(`/test_plan/${project_id}/search/${key_word}/`)
+  .then(response=>{
+    return response.data
+  })
+  .catch(error=>{
+    return error
+  })


Suggested change

await AuthClient.post(`/test_plan/${project_id}/search/${key_word}/`)

.then(response=>{

return response.data

})

.catch(error=>{

return error

})

return await AuthClient.post(`/test_plan/${project_id}/search/${key_word}/`)

handle it with try and catch when you call it

maayarosama · 2024-08-14T09:34:11Z

client/src/api/axios.ts

+  })
+}
+
+async function DeletePlan(project_id:any,test_plan_id:any) {


maayarosama · 2024-08-14T09:34:23Z

client/src/api/axios.ts

+  })
+}
+
+async function UpdatePlanTitle(project_id:any,test_plan_id:any,title:any) {


maayarosama · 2024-08-14T09:34:54Z

client/src/components/NewPlan.vue

+            <v-divider></v-divider>
+            <v-card-actions>
+            <v-btn color="primary" @click="dialog = false">Close</v-btn>
+            <v-btn color="success" @click="createTestPlan">Create</v-btn>


add loading and disabled props

maayarosama · 2024-08-14T09:35:15Z

client/src/components/NewPlan.vue

+        type: null,
+        });
+
+        const createTestPlan=async()=>{


implement notifier

maayarosama · 2024-08-14T10:25:31Z

server/test_tracker/views/dashboard.py

remove changes made in this file

maayarosama · 2024-08-14T10:25:43Z

server/test_tracker/views/project.py

maayarosama · 2024-08-14T10:25:52Z

server/test_tracker/views/test_plan.py

maayarosama · 2024-08-14T10:26:03Z

server/test_tracker/views/test_suites.py

Mahmoud-Emad

Good job ya Nabila

Mahmoud-Emad · 2024-08-25T07:52:32Z

client/src/api/axios.ts

+  baseURL: 'https://server.gent02.dev.grid.tf/api',
  timeout: 1000,
  headers: {
    'Content-Type': 'application/json',
-    'Authorization': 'Bearer ' + localStorage.getItem("token"),
+    Authorization: 'Bearer ' + localStorage.getItem('token'),
  },
-});
+})


As I mentioned earlier, this should be loaded from the window. Also, I've noticed that you and @abdahmed22 are re-implementing the same functionality in several open PRs. What do you think about creating a new PR with only these changes and merging it into your base branch to incorporate the changes you both made?

Mahmoud-Emad · 2024-08-25T07:53:37Z

client/src/api/axios.ts

-export { AuthClient, BaseClient };
+async function GetPlans (projectId:string) {
+  try {
+    localStorage.setItem('token', 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ0b2tlbl90eXBlIjoiYWNjZXNzIiwiZXhwIjoxNzIzNzI0Njg5LCJpYXQiOjE3MjM3MTUzODksImp0aSI6IjlmNTU1NmY0MjQzZTRjMmI5OWZmZTcxYjFkNWQxYmJiIiwidXNlcl9pZCI6MSwiZW1haWwiOiJuYWJpbGFAZ21haWwuY29tIn0.OUIvvLV5sgtyVQM_PtLu4HsqJaeOLC5FIx7w39VZ7js')


We agree about the idea of the tokens no? We must not hard-code a user secret and push it into GitHub

Mahmoud-Emad · 2024-08-25T07:53:50Z

client/src/api/axios.ts

+  }
+}
+
+async function SearchPlans (projectId:any, keyWord:any) {


Let's define the types

Mahmoud-Emad · 2024-08-25T07:54:25Z

client/src/components/NewPlan.vue

+          notifier.notify({
+            title: 'Success',
+            description: 'plan created successfully',
+            showProgressBar: true,
+            timeout: 7_000,
+            type: 'success',
+          })
+        } catch (error) {
+          console.error(error)
+          notifier.notify({
+            title: 'Fail',
+            description: 'Failed to create plan',
+            showProgressBar: true,
+            timeout: 7_000,
+            type: 'error',
+          })
+        } finally {


Please do the same here

Mahmoud-Emad · 2024-08-25T07:55:22Z

client/src/pages/AddTestPlan.vue

+        // const testPlans = ref([{id: '1',title: 'Plan A',created: '2024-08-01',modified: '2024-08-05'},
+        //                     {id: '1',title: 'Plan A',created: '2024-08-01',modified: '2024-08-05'},
+        //                     {id: '1',title: 'Plan A',created: '2024-08-01',modified: '2024-08-05'}
+        // ]);


Please remove this dummy data

Mahmoud-Emad · 2024-08-25T07:58:36Z

client/src/pages/AddTestPlan.vue

+            }
+        };
+
+        async function updatePlan(planId){


Define the type of planId

Mahmoud-Emad · 2024-08-25T07:58:50Z

client/src/pages/AddTestPlan.vue

+        const title=ref("");
+
+
+        function openDeleteDialog(plan) {


Define the type of plan

Mahmoud-Emad · 2024-08-25T07:58:57Z

client/src/pages/AddTestPlan.vue

+            dialogDelete.value = true;
+        }
+
+        function openUpdateDialog(plan){


Define the type of plan

Mahmoud-Emad · 2024-08-25T08:08:46Z

server/test_tracker/views/test_suites.py


    serializer_class = TestSuitesDetailSerializer
-    permission_classes = (HasProjectAccess,)
+    # permission_classes = (HasProjectAccess,)


Please don't push this, apply this on all backend commented code

Mahmoud-Emad · 2024-08-25T08:09:08Z

server/settings.py

 DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField"
 AUTH_USER_MODEL = "test_tracker.User"

+print("config",config("CLIENT_DOMAIN_NAME"))


Remove the debug line

nabilasherif added 9 commits August 11, 2024 17:57

new test suite dialog

0335e05

connecting to backend

70fa98e

testsuite page

1b74c42

getplans, searchplans, template

411233e

update, delete a plan menu

27e669b

new plan dialog

8b5b506

new plan dialog

6cd105d

connecting update title

e05c302

delete, edit icons and delete dialog

1eb63ec

maayarosama suggested changes Aug 14, 2024

View reviewed changes

nabilasherif added 3 commits August 14, 2024 17:33

ui modification + update title

89c3166

adding props

0dda8b9

notifier, try and catch and merging with dev2

9a95805

Mahmoud-Emad requested changes Aug 25, 2024

View reviewed changes

Conversation

nabilasherif commented Aug 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mahmoud-Emad left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

nabilasherif commented Aug 12, 2024 •

edited

Loading