Skip to content

Readme typo and get_article crash fix #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codesalatdev merged 2 commits into from
May 25, 2025
Merged

Readme typo and get_article crash fix #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5b9f93
Fixes tiny typo in the readme
TheNetworkGuy May 24, 2025
e63ede2
Fallback should there be no markup for a specific product
TheNetworkGuy May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ $ pip install python-picnic-api2
Then create a new instance of `PicnicAPI` and login using your credentials:

```python
from python_picnic_api import PicnicAPI
from python_picnic_api2 import PicnicAPI

picnic = PicnicAPI(username='username', password='password', country_code="NL")
```
Expand Down Expand Up @@ -99,4 +99,4 @@ picnic.get_delivery_slots()

```python
{'delivery_slots': [{'slot_id': 'XXYYZZ', 'hub_id': 'YYY', 'fc_id': 'FCX', 'window_start': '2025-04-29T17:15:00.000+02:00', 'window_end': '2025-04-29T19:15:00.000+02:00'...
```
```
2 changes: 1 addition & 1 deletion src/python_picnic_api2/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@
return None

color_regex = re.compile(r"#\(#\d{6}\)")
producer = re.sub(color_regex, "", str(article_details[1]["markdown"]))
producer = re.sub(color_regex, "", str(article_details[1].get("markdown", "")))

Check warning on line 117 in src/python_picnic_api2/client.py

View check run for this annotation

Codecov / codecov/patch

src/python_picnic_api2/client.py#L117 

Added line #L117 was not covered by tests
article_name = re.sub(color_regex, "", str(article_details[0]["markdown"]))

article = {"name": f"{producer} {article_name}", "id": article_id}
Expand Down