fix: set usage-app to vscode on coder ssh#442
Merged
bcpeinhardt merged 3 commits intomainfrom Mar 4, 2025
Merged
Conversation
bcpeinhardt
approved these changes
Mar 3, 2025
Contributor
bcpeinhardt
left a comment
bcpeinhardt
left a comment
There was a problem hiding this comment.
Nice 😎 Mind adding a snippet to the Unreleased section of the Changelog? After that it's good to go for me :)
ethanndickson
force-pushed
the
ethan/set-usage-app
branch
from
0493ce5 to
0548280
Compare
Member
Author
|
All done! Though I don't have perms to merge, so you'll need to do that for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes coder/coder#16746
Full credit to Asher for noticing why this broke!
I haven't tested this with the actual vscode extension, but the counter on the dashboard did increment after running
coder ssh <ws> --usage-app=vscode, and I was unable to get it to increment otherwise.