Skip to content

fix: embed timezone database via time/tzdata #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtojek merged 2 commits into from
Feb 6, 2026
+5 −2
Merged

fix: embed timezone database via time/tzdata #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb92105
fix: embed timezone database via time/tzdata import
mtojek Feb 6, 2026
ad25925
test: use non-UTC timezone in integration test to exercise tzdata embed
mtojek Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func TestIntegration(t *testing.T) {
"workspace_preset.parameters.param": `preset param value`,
"workspace_preset.prebuilds.instances": `1`,
"workspace_preset.prebuilds.expiration_policy.ttl": `86400`,
"workspace_preset.prebuilds.scheduling.timezone": `UTC`,
"workspace_preset.prebuilds.scheduling.timezone": `America/New_York`,
"workspace_preset.prebuilds.scheduling.schedule0.cron": `\* 8-18 \* \* 1-5`,
"workspace_preset.prebuilds.scheduling.schedule0.instances": `3`,
"workspace_preset.prebuilds.scheduling.schedule1.cron": `\* 8-14 \* \* 6`,
Expand Down
2 changes: 1 addition & 1 deletion integration/test-data-source/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ data "coder_workspace_preset" "preset" {
ttl = 86400
}
scheduling {
timezone = "UTC"
timezone = "America/New_York"
schedule {
cron = "* 8-18 * * 1-5"
instances = 3
Expand Down
3 changes: 3 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ package main

import (
"flag"
// Embed timezone data for use in environments that may not have the
// timezone database available (e.g. scratch Docker images).
_ "time/tzdata"

"github.com/hashicorp/terraform-plugin-sdk/v2/plugin"

Expand Down