Conversation
|
@matifali a little more context: |
|
@renebarak thanks for the PR! There were a couple of other changes required to support a custom GitHub URL and I made a new PR with them: #4. I don't have access to a GitHub enterprise instance - would you be able to check if the new version of the action works for you? You can use it in a workflow like so: # ...
steps:
- name: Start Coder workspace
uses: coder/start-workspace-action@2ef956daeea4f43565d6db29972e20adf9f653b6
# ... |
|
@hugodutka thank you for making this change. Unfortunately, it didn't work for me. I'm running into an issue detecting a username: On a separate note, I noticed some other potential limitations:
|
|
@renebarak Could you try using
The action must currently be used in an issue context. It was meant to be triggered by a user tagging
Good feedback, thanks! |
|
Still no luck, I get the same error. |
|
@renebarak I modified my PR to get the GitHub instance URL from the GitHub Actions context instead of action input. Hopefully that fixes the issue - could you try it out? |
|
Thanks, @hugodutka. Progress but running into a different error now: We have external authentication configured with our Enterprise GitHub and I have already authenticated. If I try to manually create a workspace in Coder, it shows as authenticated and is not prompting me to authenticate. I can also confirm the same username exists in Coder. |
|
Ah, I see. This is a limitation of Coder itself at the moment. Our HTTP API only allows looking up users by their github.com user ID, and not by github enterprise ids. I'll open an issue about this. I know it's not an ideal solution, but in the meantime you can use the |
|
For reference, I created an issue in coder/coder to track this. |
|
Great, missed that input, makes it even easier. I can confirm I have successfully created a workspace from the version you shared. Please let me know when it makes it to the official release. Thank you for making this change! |
|
@renebarak v0.2.0 is released. |
This change is adding support for custom GitHub URL value (e.g., to support Enterprise GitHub URLs). It is backwards compatible with the previous version and uses the same default as before.