fix: add diagnostic logging to Windows sign script#45
Merged
ibetitsmike merged 2 commits intomainfrom Mar 5, 2026
Merged
Conversation
Tauri's bundler output_ok() discards subprocess stdout/stderr when the sign command exits non-zero, making failures invisible. The sign script has been running and failing silently for three releases. Changes: - sign-windows.ps1: Add Start-Transcript file logging, validate all prerequisites (java, jsign jar, certificate, env vars) with explicit error messages before attempting to sign - release.yml: Add RUST_LOG=debug for bundler-side logging, add post-failure step to dump the sign script transcript log
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Windows release build fails during code signing with:
Root cause: The composite action writes the EV signing certificate using PowerShell's
Set-Content, which can prepend a UTF-8 BOM (byte order mark). The BOM bytes corrupt the PEM header (-----BEGIN CERTIFICATE-----), causing Java's X509Factory to fail to parse it.Fix
.github/actions/setup-windows-signing/action.yml:Set-Contentwith[System.IO.File]::WriteAllText()using explicitUTF8Encoding($false)(no BOM)-----BEGINscripts/sign-windows.ps1: (from prior commit)Start-Transcriptfile logging so sign failures are visible.github/workflows/release.yml: (from prior commit)RUST_LOG=tauri_bundler=debugfor bundler debug output