fix: add ~75s grace period for Codex review CI check#42
Merged
ibetitsmike merged 2 commits intomainfrom Mar 5, 2026
Merged
Conversation
The Codex review step was failing immediately when Codex hadn't responded yet. Now retries up to 6 times at 15s intervals (~75s) before giving up, while still failing immediately if there are actual comments to address.
GitHub GraphQL returns 'chatgpt-codex-connector[bot]' for reaction users but 'chatgpt-codex-connector' for comment authors. Use startswith() instead of exact match for reactions. Also fix pushedDate null handling: jq -r turns null into the string "null" which breaks timestamp comparison. Use // "" to get an empty string instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for the Codex review CI check:
Grace period — retry up to 6 times at 15s intervals (~75s) when Codex hasn't responded yet, instead of failing immediately.
Bot login mismatch — GitHub GraphQL returns
chatgpt-codex-connector[bot]for reaction users butchatgpt-codex-connectorfor comment authors. The thumbs-up check now usesstartswith()so it matches both formats.Null pushedDate — when
pushedDateis null,jq -routputs the string"null"which broke the timestamp comparison. Now correctly outputs an empty string.Changed:
.github/workflows/pr.yml,scripts/check_codex_comments.sh