🤖 fix: run coder config-ssh on app startup #1761
Conversation
Refresh Coder SSH config during ServiceContainer initialization. This handles cases where the coder binary moves on restart (e.g., self-updating installers or temp paths). - Check if coder is available first via getCoderInfo() - Fire-and-forget to avoid blocking startup - Logs warning on failure but doesn't crash
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c89a1eabe
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
- Call ensureSSHConfig() directly instead of checking getCoderInfo() first - This avoids caching 'unavailable' if coder isn't installed at startup - User can install coder mid-session and it will be detected correctly - Remove unused log import
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
1 participant
Problem
When the
coderbinary moves on restart (e.g., self-updating installers or temp paths), the SSH config written bycoder config-sshbecomes stale. The config points to the old binary location, breaking SSH connections to Coder workspaces.Previously,
coder config-ssh --yesonly ran once per workspace during initial setup—not on app restart.Solution
Run
coder config-ssh --yesonce duringServiceContainer.initialize():getCoderInfo()(no-op if coder not installed)Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high• Cost:$1.63