Skip to content

Conversation

@ammar-agent
Copy link
Collaborator

@ammar-agent ammar-agent commented Jan 18, 2026

Summary

  • move UI-only tool payloads into ui_only (ask_user_question, file_edit, notify) with model-facing summaries
  • update UI/tool consumers to read ui_only and fall back for legacy history
  • strip only ui_only in provider requests and remove toolOutputRedaction plumbing
  • prefer ui_only.file_edit.diff when extracting edited file diffs for compaction attachments

Why

  • keep model context concise while preserving rich UI rendering without per-tool redaction

Testing

  • bun test src/common/utils/messages/extractEditedFiles.test.ts
  • make static-check

Generated with mux • Model: openai:gpt-5.2-codex • Thinking: xhigh • Cost: $28.50

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05a03427d3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ammar-agent
Copy link
Collaborator Author

@codex review

Addressed the compaction diff issue by preferring ui_only.file_edit.diff in extractEditedFileDiffs and added coverage in extractEditedFiles.test.ts.

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Ensure edited file diff extraction prefers ui_only.file_edit.diff when present.

---

_Generated with `mux` • Model: `openai:gpt-5.2-codex` • Thinking: `xhigh` • Cost: `8.50`_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant