🤖 fix: allow image deletion when editing messages #1700
Merged
+103
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when editing a message with attached images, users could not remove those images - the remove button was hidden. Additionally, even if removal was enabled, the backend would preserve the original images when imageParts was empty (treating it the same as omitted). Changes: - Frontend: Always pass imageParts during edit (even if empty) so the backend knows removals are intentional - Backend: Only preserve original attachments when imageParts is undefined, not when it's an explicit empty array - Enable the remove button in ImageAttachments during edit mode Fixes the issue where users couldn't delete images from messages they were editing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When editing a message with attached images, users could not remove those images - the remove (×) button was hidden.
Changes
imagePartsduring edit (even if empty) so the backend knows removals are intentionalimagePartsisundefined, not when it's an explicit empty arrayImageAttachmentsduring edit modeTesting
Tested manually:
Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high• Cost:$0.88