Skip to content

Conversation

@ibetitsmike
Copy link
Contributor

Fixes the bottom Retry banner flickering during auto-retry loops by keeping the RetryBarrier visible until the retry stream produces real output, and suppressing the StreamingBarrier while the retry banner is shown.

  • Adds a small predicate in retryEligibility.ts to detect "retry stream started but no tokens yet".
  • Updates AIView to use this predicate + persisted retry attempt state.

Validation:

  • bun test src/browser/utils/messages/retryEligibility.test.ts
  • make static-check

Generated with mux • Model: openai:gpt-5.2 • Thinking: xhigh • Cost: $6.22

@github-actions github-actions bot added the enhancement New feature or functionality label Jan 15, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11a3acccd0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@ibetitsmike
Copy link
Contributor Author

@codex review

Addressed the TTFT regression by restoring the !canInterrupt gate for the hasInterruptedStream(...) branch and expanding the retry-sticky predicate to cover the common case where no assistant DisplayedMessage exists until the first delta.

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant