Skip to content

chore: fix node image to fall back to node 22 for armv7 #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnstcn merged 1 commit into from
Jan 12, 2026
Merged

chore: fix node image to fall back to node 22 for armv7 #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions images/node/ubuntu.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,19 @@ FROM codercom/enterprise-base:ubuntu
# Run everything as root
USER root

# Install whichever Node version is LTS
RUN curl -sL https://deb.nodesource.com/setup_lts.x | bash -
RUN DEBIAN_FRONTEND="noninteractive" apt-get update -y && \
ARG TARGETARCH
ARG TARGETVARIANT

# Install Node.js with platform-specific version
# armv7: Node.js 22.x (last version with armv7 support)
Copy link
Member

@matifali matifali Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider dropping support for armv7 at sometime.

Copy link
Member Author

@johnstcn johnstcn Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that was my other thought but I think we still have folks who enjoy running Coder on older Raspberry Pis?

Copy link
Member

@matifali matifali Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah may be. I don't have any data. But armv7 is being slowly deprecated across many projects

# others: Latest LTS
# Ref: https://github.com/nodesource/distributions/issues/1881
RUN NODE_VERSION="lts"; \
if [ "${TARGETARCH}${TARGETVARIANT}" = "armv7" ]; then \
NODE_VERSION="22"; \
fi && \
curl -sL https://deb.nodesource.com/setup_${NODE_VERSION}.x | bash - && \
DEBIAN_FRONTEND="noninteractive" apt-get update -y && \
apt-get install -y nodejs

# Install Yarn
Expand Down
1 change: 1 addition & 0 deletions scripts/images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

set -euo pipefail

# IMAGES defines the list of images to build/push IN ORDER.
IMAGES=(
"base"
"minimal"
Expand Down
Loading