feat: add Prometheus metrics for observability#177
Merged
Conversation
Add Prometheus metrics to expose request success/failure counts and
error types so operators can monitor and alert on API communication
issues.
New metrics:
- coder_logstream_requests_total{status} - tracks success/failure counts
- coder_logstream_errors_total{type} - tracks errors by type (network)
New flag:
- --metrics-addr / CODER_LOGSTREAM_METRICS_ADDR (default :9100)
Starts an HTTP server serving /metrics for Prometheus scraping.
Instrumented paths:
- PostLogSource failures
- ConnectRPC28WithRole / ConnectRPC20 failures
- Log Send failures
- All success paths
Resolves #173, partially addresses #146
deansheather
reviewed
Mar 3, 2026
…Total Address review feedback from @deansheather: - Replace scattered metric calls with an instrumentedClient wrapper around agentsdk.Client that records metrics in one place - Remove redundant errorsTotal metric (was always incremented alongside requestsTotal failure) - Add method label to requestsTotal for better granularity: PostLogSource, ConnectRPC, SendLog
deansheather
reviewed
Mar 3, 2026
Address review feedback: - Replace global prometheus metrics with a metricsCollector struct holding a custom prometheus.Registry, passed to all components - Use requestMethod enum (methodPostLogSource, methodConnectRPC, methodSendLog) instead of raw strings - Tests create fresh metricsCollector instances, avoiding flakes from shared global state in parallel test execution
deansheather
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Prometheus metrics to expose request success/failure counts and error types so operators can monitor and alert on API communication issues.
New metrics
coder_logstream_requests_total{status}— tracks success/failure countscoder_logstream_errors_total{type}— tracks errors by type (network)New flag
--metrics-addr/CODER_LOGSTREAM_METRICS_ADDR(default:9100)Starts an HTTP server serving
/metricsfor Prometheus scraping.Instrumented paths
Resolves #173, partially addresses #146