fix: startup reliability, ConnectOnLaunch wiring, and reconnect UX#3
Merged
ethanndickson merged 1 commit intomainfrom Mar 5, 2026
Merged
fix: startup reliability, ConnectOnLaunch wiring, and reconnect UX#3ethanndickson merged 1 commit intomainfrom
ethanndickson merged 1 commit intomainfrom
Conversation
- Add bounded startup retry (5 attempts with exponential backoff) for RPC reconnect to handle boot race when VPN service socket isn't ready - Wire ConnectOnLaunch setting into startup so VPN auto-starts when setting is enabled and all prerequisites are met - Fix inverted reconnect button logic: enable in Disconnected state (when user needs it), disable during Connecting - Fix SpeakerOnError fire-and-forget: properly await Reconnect via Task.Run instead of using var on a Task (which is a no-op Dispose) - Fix settings page copy: 'Windows startup' -> 'when you sign in'
Member
Author
|
Gonna test this for a few days and merge if it works |
Member
Author
|
Works well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
CoderConnectSettings.ConnectOnLaunchinto startup flow and auto-start VPN when prerequisites are met:RpcController.SpeakerOnErrorfire-and-forget reconnect path to correctly run reconnect asynchronously with warning logs on failure.Why
This addresses startup reliability and UX regressions where:
Validation
dotnet restore Coder.Desktop.slndotnet build Coder.Desktop.sln -c Release --no-restoredotnet test Tests.CoderSdk/Tests.CoderSdk.csproj --no-restore -v qdotnet test Tests.Vpn.Proto/Tests.Vpn.Proto.csproj --no-restore -v qdotnet test Tests.Vpn/Tests.Vpn.csproj --no-restore -v qdotnet test Tests.Vpn.Service/Tests.Vpn.Service.csproj --no-restore -v qAll listed tests passed.
Risk / rollback
cc1dcef.