fix: wire sign-in pages to injected viewmodel#2
Merged
ethanndickson merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
Member
Author
|
Tested and it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SignInWindow.UpdateStage()to instantiate sign-in pages with the sharedSignInViewModelconstructor.page.DataContext = _vmassignment inUpdateStage()because constructors already set DataContext.Why
The token page button handler (
GenerateTokenButton_Click) and other code-behind handlers read the pageViewModelproperty, notDataContext.UpdateStage()previously created pages with parameterless constructors, leavingViewModelnull and causing handlers to no-op (including "Generate a token via the Web UI").Validation
dotnet restore App.Avalonia/App.Avalonia.csproj -v qNo .NET SDKs were found).Risk / rollback
d5f4d65.