helm: move verbose and sign args outside artifactory check#121
Conversation
Move --verbose and --sign arguments outside of the artifactory.enabled if-else block so they are applied regardless of artifactory configuration. Previously, these arguments were only applied when artifactory was disabled. Co-authored-by: bjornrobertsson <572461+bjornrobertsson@users.noreply.github.com>
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
The CLA Assistant check is failing because the bot account needs to sign the CLA. This is expected for automated contributions. A human maintainer can bypass this check when reviewing the PR, or the bot account can be added to the CLA allowlist if desired. The actual code changes have passed the helm linting checks successfully. ✅ |
This PR fixes an issue where the
--verboseand--signarguments were only applied when artifactory was disabled.Changes:
--verboseand--signargument blocks outside of theartifactory.enabledif-else statementBefore: Arguments were only added when
persistence.artifactory.enabledwasfalseAfter: Arguments are added based on
verboseLoggingandextensionSigningvalues regardless of artifactory configurationResolves the issue described in lines 75-80 of
helm/templates/deployment.yaml.