fix: capture timestamps at AsyncRecorder call-time#202
Closed
dannykopping wants to merge 1 commit intomainfrom
Closed
fix: capture timestamps at AsyncRecorder call-time#202dannykopping wants to merge 1 commit intomainfrom
dannykopping wants to merge 1 commit intomainfrom
Conversation
AsyncRecorder dispatches records asynchronously via goroutines. Previously, timestamps (CreatedAt/EndedAt) were not set before the goroutine launch, meaning the timestamp would reflect when the record was eventually persisted rather than when the event actually occurred. This captures timestamps at method call-time, before the goroutine is launched, ensuring they accurately reflect when the event happened regardless of async dispatch delays.
dannykopping
force-pushed
the
fix/async-recorder-timestamps
branch
from
5469a38 to
329db62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture timestamps at
AsyncRecordercall-time, before async dispatch. This ensures we trust the source timestamp (when the event was recorded) rather than the server timestamp (when it was eventually persisted).